[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534124#comment-15534124 ]
Jeremiah Jordan commented on CASSANDRA-12681: --------------------------------------------- [~jjirsa] since this is not a bug fix, and it breaks anything doing stuff like mentioned in CASSANDRA-4795 I really think we should revert this from 3.0.10 and possibly only commit it to 4.0. This is a breaking "API" change/behavior. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > ------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata > Reporter: Nachiket Patil > Assignee: Nachiket Patil > Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)