[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534866#comment-15534866 ]
Jeff Jirsa edited comment on CASSANDRA-12681 at 9/30/16 3:12 AM: ----------------------------------------------------------------- Reverted in 3.0 ( {{cd8a98a2dd2d7e4993cd1aa3c282602b48be73c8}} ) and 3.X ( {{02404115e0db1762473556f985c8e5388db92da6}} ), updated NEWS.txt to be more descriptive in trunk/4.0: {code} - Cassandra will no longer allow invalid keyspace replication options, such as invalid datacenter names for NetworkTopologyStrategy. Operators MUST add new nodes to a datacenter before they can set set ALTER or CREATE keyspace replication policies using that datacenter. Existing keyspaces will continue to operate, but CREATE and ALTER will validate that all datacenters specified exist in the cluster. {code} Apologies to you folks for the inconvenience. Having been on the wrong side of API changes in minor versions, I should have been more sensitive to this. was (Author: jjirsa): Reverted in 3.0 ( {{cd8a98a2dd2d7e4993cd1aa3c282602b48be73c8}} ) and 3.X ( {{02404115e0db1762473556f985c8e5388db92da6}} ), updated NEWS.txt to be more descriptive in trunk/4.0: {code} - Cassandra will no longer allow invalid keyspace replication options, such as invalid datacenter names for NetworkTopologyStrategy. Operators MUST add new nodes to a datacenter before they can set set ALTER or CREATE keyspace replication policies using that datacenter. Existing keyspaces will continue to operate, but CREATE and ALTER will validate that all datacenters specified exist in the cluster. {code} Apologies to you DSE folks for the inconvenience. Having been on the wrong side of API changes in minor versions, I should have been more sensitive to this. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > ------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata > Reporter: Nachiket Patil > Assignee: Nachiket Patil > Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)