[ 
https://issues.apache.org/jira/browse/CASSANDRA-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607334#comment-15607334
 ] 

Jeff Jirsa commented on CASSANDRA-12837:
----------------------------------------

This is not a review, but a few notes:

- 2.2.x isn't getting new features, and a feature that adds thread pool 
executors probably belongs in 3.X at the newest (3.10, not 2.1/2.2/3.0). 

- We have other ways of doing parallel compaction that's used by 
cleanup/scrub/upgradesstables - 
https://github.com/apache/cassandra/blob/f2a354763877cfeaf1dd017b84a7c8ee9eafd885/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L287
 - would it be reasonable to try to utilize that, rather than building your 
multi-threading and adding new executor pools?

-  Why does this rely on Murmur3 partitioner? Why wouldn't it be possible with 
{{RandomPartitioner}} ? Or any of the others? 

-  This may be less important with CASSANDRA-11218 


> Add multi-threaded support to nodetool rebuild_index
> ----------------------------------------------------
>
>                 Key: CASSANDRA-12837
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12837
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: vincent royer
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.2.9
>
>         Attachments: CASSANDRA-12837-2.2.9.txt
>
>
> Add multi-thread nodetool rebuild_index to improve performances.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to