[ https://issues.apache.org/jira/browse/CASSANDRA-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681151#comment-15681151 ]
Jason Brown commented on CASSANDRA-12934: ----------------------------------------- Patch available here: ||3.0||3.x|| |[branch|https://github.com/jasobrown/cassandra/tree/anticompaction-serializer_3.0]|[branch|https://github.com/jasobrown/cassandra/tree/anticompaction-serializer_3.x]| |[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-anticompaction-serializer_3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-anticompaction-serializer_3.x-dtest/]| |[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-anticompaction-serializer_3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-anticompaction-serializer_3.x-testall/]| As I wanted to ensure that what gets deserialized is exactly what was serialized (and that the sizes are the same), I added {{equals}} and {{hashCode}} methods to {{AnticompactionRequestSerializer}}. After I wrote the test class, I decided to go nuts and added {{equals}} and {{hashCode}} methods to all of the subclasses of {{RepairMessage}} and added them to the test. > AnticompactionRequestSerializer serializedSize is incorrect > ----------------------------------------------------------- > > Key: CASSANDRA-12934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12934 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Jason Brown > Assignee: Jason Brown > Fix For: 3.0.x, 3.x > > > {{AnticompactionRequestSerializer#serializedSize}} does not add the size of > the {{#successfulRanges}} list to the total byte count. > This incorrectly calculated size shouldn't affect anything in the current > release AFAICT, but it is a blocker for CASSANDRA-8457. -- This message was sent by Atlassian JIRA (v6.3.4#6332)