[ https://issues.apache.org/jira/browse/CASSANDRA-12915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701994#comment-15701994 ]
Corentin Chary commented on CASSANDRA-12915: -------------------------------------------- Updated the pull request: * Restored the primary code and created a one-line commit to fix it (the pull request contains both commits) * See the pasted log to get an idea on the effects: on this query it avoids one search on an index that would return 600k tokens and and two iterations on results that would also contain 600k tokens. The results would be way better if we had a proper estimation of the cardinality of the index, which we can get in a second time. If we had it we could easily skip both huge searches. I'll add tests once we agree on the code :). > SASI: Index intersection can be very inefficient > ------------------------------------------------ > > Key: CASSANDRA-12915 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12915 > Project: Cassandra > Issue Type: Improvement > Components: sasi > Reporter: Corentin Chary > Fix For: 3.x > > > It looks like RangeIntersectionIterator.java and be pretty inefficient in > some cases. Let's take the following query: > SELECT data FROM table WHERE index1 = 'foo' AND index2 = 'bar'; > In this case: > * index1 = 'foo' will match 2 items > * index2 = 'bar' will match ~300k items > On my setup, the query will take ~1 sec, most of the time being spent in > disk.TokenTree.getTokenAt(). > if I patch RangeIntersectionIterator so that it doesn't try to do the > intersection (and effectively only use 'index1') the query will run in a few > tenth of milliseconds. > I see multiple solutions for that: > * Add a static thresold to avoid the use of the index for the intersection > when we know it will be slow. Probably when the range size factor is very > small and the range size is big. > * CASSANDRA-10765 -- This message was sent by Atlassian JIRA (v6.3.4#6332)