[ https://issues.apache.org/jira/browse/CASSANDRA-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705993#comment-15705993 ]
Aleksey Yeschenko commented on CASSANDRA-12716: ----------------------------------------------- bq. I wanted to make sure we properly rejecting early old sstables {{StartupChecks.checkSSTablesFormat}} should be the place to do it, but I've seen reports of it not triggering early enough. The extra validation in {{Descriptor.fromFileName()}} isn't too ugly though, so ¯\_(ツ)_/¯ . There are some unused methods/fields/constants here and there (starting with {{LegacyLayout}}), and instances where we can now reduce method visibility (e.g. many in {{SchemaKeyspace}} that no longer need to be visible as {{LegacySchemaMigrator(Test)}} are gone for good). Doesn't look like anything is broken, or obviously present that should and can also be removed - until Thrift is gone too. +1. > Remove pre-3.0 compatibility code for 4.0 > ----------------------------------------- > > Key: CASSANDRA-12716 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12716 > Project: Cassandra > Issue Type: Improvement > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 4.0 > > > CASSANDRA-8099 make subsequent changes to internal formats so that we have > quite a bit of backward compatibility code a bit over the place. Due to that, > but also as a natural evolution, I believe we always had a tacit agreement > that 3.0/3.X would be a mandatory step on the upgrade to 4.X, so that we can > remove pre-3.0 compatibility (that is, we won't support going from any 2.x > release directly to 4.0, you'll have to upgrade to at least some 3.0 release > first). > I think it's time to create the 4.0 branch and remove that pre-3.0 backward > compatibility code, which should clean code quite a bit, and that's the goal > of this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)