[ https://issues.apache.org/jira/browse/CASSANDRA-11115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-11115: ----------------------------------------- Reviewer: Aleksey Yeschenko Fix Version/s: (was: 4.x) 4.0 Status: Patch Available (was: Open) Attaching patch on current trunk below: | [11115|https://github.com/pcmanus/cassandra/commits/11115] | [utests|http://cassci.datastax.com/job/pcmanus-11115-testall] | [dtests|http://cassci.datastax.com/job/pcmanus-11115-dtest] | There is a few different commits but they are more iterations of things I removed so it might be easier to look at the change as a whole. By and large, this remove things, lots of them, and a few minor related cleanups. There is 2 small points worthy of notice however: * {{StorageService.describeRing()}}, which we still expose through a JMX method was using a thrift class, on which the {{toString()}} was called on for the JMX method. To preserve backward compatibility, I re-created an equivalent (though simpler) class ({{TokenRange}}), which should mantain the same {{toString()}} output. * {{ConfigHelper}} was fun because it was still using some thrift and I know next to nothing on hadoop. From what I can tell, most of it was left-over from when we had thrift-based hadoop clients, with the exception of the user for the {{INPUT_KEYRANGE_CONFIG}}, where we were using a thrift object and thrift complex serialization to basically encode 2 strings (token strings at that, so with only hexadecimal characters). I replaced that by something much simpler, but the one I'm not 100% sure is if that breaks some backward compatibility. I don't think it does, but I'm again not knowledgeable of this enough to be 100% assertive. Also, I want to look at the method visibility in {{SchemaKeyspace}} discussed on CASSANDRA-12716, and have 2-3 points on my TODO list to check if we can simplify, so I may add one commit in the next few days, but as it'll be pretty minor in any case, attaching so review is not blocked on that. > Thrift removal > -------------- > > Key: CASSANDRA-11115 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11115 > Project: Cassandra > Issue Type: Improvement > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 4.0 > > > Thrift removal [has been announced for > 4.0|http://mail-archives.apache.org/mod_mbox/cassandra-user/201601.mbox/%3ccaldd-zgagnldu3pqbd6wp0jb0x73qjdr9phpxmmo+gq+2e5...@mail.gmail.com%3E]. > This ticket is meant to serve as a general task for that removal, but also > to track issue related to that, either things that we should do in 3.x to > make that removal as smooth as possible, or sub-tasks that it makes sense to > separate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)