[ 
https://issues.apache.org/jira/browse/CASSANDRA-13106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Zhou resolved CASSANDRA-13106.
------------------------------------
    Resolution: Cannot Reproduce

Hi Benedict,
Sorry for the spam and thanks for the reply. I just thought this was a quick 
fix. Closing this ticket as I lost the original stack trace and thus cannot 
double confirm the CPU utilization issue was caused by 
Predicates.<SSTableReader>alwaysTrue().

> Unnecessary assertion
> ---------------------
>
>                 Key: CASSANDRA-13106
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13106
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Simon Zhou
>            Assignee: Simon Zhou
>            Priority: Minor
>         Attachments: CASSANDRA-13106.patch
>
>
> We had over 70 thousand sstables and it's slow to bootstrap new node, even 
> though the CPU utilization for main thread of Cassandra was nearly 100%. So 
> we took a few stack traces and found that the main thread were busy running 
> this line in Tracker.java:
> {code}
> assert Iterables.all(removed, remove);
> {code}
> Not exactly sure whether this line causes CPU utilization/bootstrapping 
> issue, but this line is redundant because the Predict we pass in is 
> Predicates.<SSTableReader>alwaysTrue(), which means the assertion always 
> returns true. So I propose to remove that line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to