[
https://issues.apache.org/jira/browse/CASSANDRA-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825832#comment-15825832
]
Stefan Podkowinski commented on CASSANDRA-13124:
------------------------------------------------
bq. Does this mean retry is broken on 3.0? Should we file a ticket for this?
From what I understood CASSANDRA-11960 only affected 3.X so I guess retry
should be working on 3.0?
You can just test it by commenting out all code in {{HintVerbHandler}}.
Afterwards the {{hintedhandoff_decom_test}} will fail due to data loss (that
was supposed to be prevented by the transferred hints). Although no hints have
been handled at all, decom will happily proceed and there won't be any
exceptions or errors in the logs.
bq. If my understanding above is correct we should probably also fix this on
3.0 to reinstate the same behavior before CASSANDRA-12905? Can you create a 3.0
patch and submit CI?
This plus removing the retry loop in the dispatcher, due to the broken
behaviour described in [my
comment|https://issues.apache.org/jira/browse/CASSANDRA-13058?focusedCommentId=15818371&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15818371],
which is what has been done for CASSANDRA-11960 as well. Afterwards retrying
hints on page basis should happen just once as initiated by
{{TransferHintsTask}} and periodically for regular hinting, executed by the
HintsDispatcher executor.
||3.0||
|[branch|https://github.com/spodkowinski/cassandra/tree/CASSANDRA-13124-3.0]|
|[dtest|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-13124-3.0-dtest/]|
|[testall|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-13124-3.0-testall/]|
> Send ack when received hint is non-local
> ----------------------------------------
>
> Key: CASSANDRA-13124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13124
> Project: Cassandra
> Issue Type: Bug
> Reporter: Paulo Motta
> Priority: Minor
>
> CASSANDRA-12905 changed the hints path to be asynchronous in the normal case,
> but when the hint is non-local and should be stored (ie. on decommission) an
> ack is not sent so the operation does not complete successfully.
> CASSANDRA-13058 fixed this for 3.0+, but for 3.11+ but there is an additional
> concern which on 3.0 is that non-acked hints are being completed successfully
> so we should probably look into this as well here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
