[ 
https://issues.apache.org/jira/browse/CASSANDRA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004768#comment-13004768
 ] 

Stephen Connolly commented on CASSANDRA-2298:
---------------------------------------------

perhaps... but i prefer not to force the issue and let the CI build define 
whether it wants the test failures to be ignored. That way you can have a set 
of different criteria.

Instrumented tests failing can actually be indicative of a number of threading 
issues.

I just want something that lets the CI build get code coverage... some people 
(including me depending on the way the wind is blowing) feel that code coverage 
when tests are failing is invalid as you are executing code paths that are not 
actually covered by the tests.  We had a system which had about 3% higher 
coverage if 3 of the test cases were failing than if they were passing... so in 
general you only trust test coverage when the tests pass

> Allow running the build with test failures ignored
> --------------------------------------------------
>
>                 Key: CASSANDRA-2298
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2298
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.8
>            Reporter: Stephen Connolly
>         Attachments: CASSANDRA-2298.patch
>
>
> When trying to get code coverage results, if there are failing tests the ANT 
> build will fail.
> Need to expose a property to allow ignoring test failures so that code 
> coverage can be recorded despite test failures (as a result of the code being 
> instrumented)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to