[ https://issues.apache.org/jira/browse/CASSANDRA-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892297#comment-15892297 ]
Robert Stupp commented on CASSANDRA-13271: ------------------------------------------ Can you please clean up the imports as they were before and remove the new, superfluous ones? The default Eclipse "organize imports" is not how we are used to do it in the C* code base (see the developer/how-to-contribute docs on cassandra.apache.org). All you need in your cassandra-fork on GitHub is a branch for this patch - not a new fork. > Reduce lock contention on instance factories of ListType and SetType > -------------------------------------------------------------------- > > Key: CASSANDRA-13271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13271 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: vincent royer > Priority: Minor > Labels: performance > Fix For: 4.x > > Attachments: 0001-CASSANDRA-13271-computeIfAbsent.patch, > 0001-CASSANDRA-13271-singleton-factory-concurrency-opimiz.patch > > > By doing some performance tests, i noticed that getInstance() in > org.apache.cassandra.db.marshal.ListType and SetType could suffer from lock > contention on the singleton factory getInstance(). Here is a proposal to > reduce lock contention by using a ConcurrentMap and the putIfAbsent method > rather than a synchronized method. -- This message was sent by Atlassian JIRA (v6.3.15#6346)