[ 
https://issues.apache.org/jira/browse/CASSANDRA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954044#comment-15954044
 ] 

Edward Capriolo edited comment on CASSANDRA-13396 at 4/3/17 7:31 PM:
---------------------------------------------------------------------

{quote}
The project has always allowed ninja fixing minor (especially non-code) things. 
Comments here are a net positive. There's no reason to fight about adding 
comments after the fact.
{quote}
No. It is important. The -1 er is using his technical insight as a 
justification for his -1. The incomplete comment shows how much time he really 
spent working on the given code. No tests, no argument checking, and a half 
done comment.


was (Author: appodictic):
{quote}
The project has always allowed ninja fixing minor (especially non-code) things. 
Comments here are a net positive. There's no reason to fight about adding 
comments after the fact.
{quote}
No. It is important. The -1 er is using his technical insight as a 
justification for his -1. The incomplete comment shows how much time he really 
spent working on the given code. 

> Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13396
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13396
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Edward Capriolo
>            Priority: Minor
>
> https://www.mail-archive.com/user@cassandra.apache.org/msg51603.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to