[
https://issues.apache.org/jira/browse/CASSANDRA-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009895#comment-16009895
]
Cameron Zemek commented on CASSANDRA-13499:
-------------------------------------------
[~vroyer59] Is there any particular reason for using the dedicated Set?
Looking at the patch the main parts seem to be
{code:title=SecondaryIndexManager.java|borderStyle=solid}
public void flushAllNonCFSBackedIndexesBlocking()
{
executeAllBlocking(indexes.values()
.stream()
.filter(index ->
!index.getBackingTable().isPresent()),
Index::getBlockingFlushTask);
}
{code}
{code:title=SecondaryIndexManager.java|borderStyle=solid}
public UpdateTransaction newUpdateTransaction(PartitionUpdate update,
OpOrder.Group opGroup, int nowInSec)
{
if (!hasIndexes())
return UpdateTransaction.NO_OP;
Index.Indexer[] indexers = indexes.values().stream()
.map(i ->
i.indexerFor(update.partitionKey(),
update.columns(),
nowInSec,
{code}
which are present in trunk. So this issue looks resolved to me.
> Avoid duplicate calls to the same custom row index
> --------------------------------------------------
>
> Key: CASSANDRA-13499
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13499
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: vincent royer
> Priority: Minor
> Fix For: 3.0.14, 3.11.0, 4.x
>
> Attachments: 0006-Avoid-duplicate-calls-to-the-same-custom-index.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Avoid duplicate calls to the same custom row index by using a dedicated
> Set<Index> rather than the collection indexes.values().
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
