[
https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032098#comment-16032098
]
Paulo Motta commented on CASSANDRA-10130:
-----------------------------------------
I also like the {{SSTableAddedNotification}} version with the memtable better.
It would be nice if you could add a short comment explaining when the memtable
is present or not.
I'm not sure we should restrict the {{SSTableLoadedNotification}} to only
loaded sstables, since a subscriber may want to do an action before and after
sstables are added to the tracker, regardless if they are flushed or externally
loaded, so we should probably trigger regardless if memtable is null or not and
rename the notification to {{SSTableBeforeAddedNotification}} (or similar) -
this will also prevent confusion from users thinking the sstables are already
in the tracker when receiving an {{SSTableLoadedNotification}}.
Also you should probably ubsubscribe from the tracker when the index is dropped.
This is looking much cleaner now, good job!
> Node failure during 2i update after streaming can have incomplete 2i when
> restarted
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-10130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
> Project: Cassandra
> Issue Type: Bug
> Components: Coordination
> Reporter: Yuki Morishita
> Assignee: Andrés de la Peña
> Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during
> MV/2i update can leave received SSTables live when restarted while MV/2i are
> partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the
> startup, or at least warn user when the node restarts.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
