[
https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050253#comment-16050253
]
Sergio Bossa commented on CASSANDRA-10130:
------------------------------------------
[~adelapena], [~pauloricardomg], excellent additions overall, just a few
comments:
* I mistakenly removed {{queryableIndexes}} in my refactor (as noted);
[this|https://github.com/adelapena/cassandra/commit/c5604ffd5ae36cc34d13af6c4c4eadba98458fa3]
commit added it back, but it's unfortunately not enough, as if the
initialization task fails, the index will never be made queryable: we need to
fix this, and we need a test for such failure case.
* Nit/OCD: I would change the
[rebuildFromSSTablesBlocking|https://github.com/adelapena/cassandra/commit/a945358a36f97632e94e9103650d72c04735354d#diff-3f2c8994c4ff8748c3faf7e70958520dR306]
signature to have the {{sstables}} first, consistently with
{{buildIndexesBlocking}}.
* In {{buildIndexesBlocking}}, any exceptions thrown by
{{flushIndexesBlocking}} in the {{finally}} block will hide previous
exceptions: we should accumulate them.
* Nit/OCD: In {{buildIndexesBlocking}}, we should put an additional comment
before invoking {{flushIndexesBlocking}}.
* If {{rebuildFromSSTablesBlocking}} is not used elsewhere, I would strongly
recommend to make it private/protected and move its comment to
{{rebuildIndexesBlocking}}: the [general
rule|https://image.slidesharecdn.com/effectivejava-2ndedition-chapter4-151203200429-lva1-app6891/95/effective-java-chapter-4-classes-and-interfaces-4-638.jpg?cb=1449173201]
is methods (as well as attributes) should have the most restricted visibility
allowed by working code.
* Regarding the {{test_standalone_scrub}} failure, I _believe_ it's due to the
fact we only manage counters in our marking methods when
{{DatabaseDescriptor.isDaemonInitialized()}}, which is obviously not the case
with the scrubber; if so, it's probably an easy fix.
> Node failure during 2i update after streaming can have incomplete 2i when
> restarted
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-10130
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
> Project: Cassandra
> Issue Type: Bug
> Components: Coordination
> Reporter: Yuki Morishita
> Assignee: Andrés de la Peña
> Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during
> MV/2i update can leave received SSTables live when restarted while MV/2i are
> partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the
> startup, or at least warn user when the node restarts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
