[
https://issues.apache.org/jira/browse/CASSANDRA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062994#comment-16062994
]
Kurt Greaves commented on CASSANDRA-13142:
------------------------------------------
[~krummas] I've updated the branch although haven't addressed your second point
yet. I agree we should block until all compactions for a given CF are finished,
however I'm having trouble identifying a way to get currently running
compaction futures. Is there some novel way to achieve this or should I just go
the route of using {{CompactionInfo.Holder}}?
Also regarding {{cfs.markAllCompacting()}}, I've changed it to take operations
to interrupt, however the main change being that it now uses
{{getUncompactingSSTables()}} rather than {{getPermittedToCompactSSTables()}}.
I believe this is OK as at the moment it's only ever called after all
compactions are stopped, so these should return the same assuming all types are
interruptible, otherwise it will return the subset of SSTables that are not
compacting and didn't get forcibly stopped. Worth checking my logic here though.
And yeah those last three points were broken because I changed tract from
"uninterruptibles" to "interruptibles" and confused myself... heh. Should be
addressed now.
[github|https://github.com/apache/cassandra/compare/cassandra-2.2...kgreav:cassandra-2.2]
> Upgradesstables cancels compactions unnecessarily
> -------------------------------------------------
>
> Key: CASSANDRA-13142
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13142
> Project: Cassandra
> Issue Type: Bug
> Reporter: Kurt Greaves
> Assignee: Kurt Greaves
> Attachments: 13142-v1.patch
>
>
> Since at least 1.2 upgradesstables will cancel any compactions bar
> validations when run. This was originally determined as a non-issue in
> CASSANDRA-3430 however can be quite annoying (especially with STCS) as a
> compaction will output the new version anyway. Furthermore, as per
> CASSANDRA-12243 it also stops things like view builds and I assume secondary
> index builds as well which is not ideal.
> We should avoid cancelling compactions unnecessarily.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
