[ https://issues.apache.org/jira/browse/CASSANDRA-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Eriksson updated CASSANDRA-13175: ---------------------------------------- Reviewer: Marcus Eriksson Just tried it and it surely looks useful I vote we add it as a new target though, and then run that target on circle-ci. Reason I think we should use a new target is that I tried Error Prone 2.1 which has a bug making it impossible to build Cassandra (https://github.com/google/error-prone/issues/711) - keeping it separate would allow us to still build it. [~spo...@gmail.com] Should we make the error-prone build clean and then commit the fixes + the build.xml changes? Or subtasks perhaps? > Integrate "Error Prone" Code Analyzer > ------------------------------------- > > Key: CASSANDRA-13175 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13175 > Project: Cassandra > Issue Type: Improvement > Reporter: Stefan Podkowinski > Assignee: Stefan Podkowinski > Attachments: 0001-Add-Error-Prone-code-analyzer.patch, > checks-2_2.out, checks-3_0.out, checks-trunk.out > > > I've been playing with [Error Prone|http://errorprone.info/] by integrating > it into the build process and to see what kind of warnings it would produce. > So far I'm positively impressed by the coverage and usefulness of some of the > implemented checks. See attachments for results. > Unfortunately there are still some issues on how the analyzer is effecting > generated code and used guava versions, see > [#492|https://github.com/google/error-prone/issues/492]. In case those issues > have been solved and the resulting code isn't affected by the analyzer, I'd > suggest to add it to trunk with warn only behaviour and some less useful > checks disabled. Alternatively a new ant target could be added, maybe with > build breaking checks and CI integration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org