[
https://issues.apache.org/jira/browse/CASSANDRA-13703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155665#comment-16155665
]
Branimir Lambov commented on CASSANDRA-13703:
---------------------------------------------
Rebased and updated the branch, reducing the visibility of {{shouldCheckCrc}}
and adding a comment and {{VisibleForTesting}} annotations to make it clear why
the shorthand methods use inconsistent parameters.
> Using min_compress_ratio <= 1 causes corruption
> -----------------------------------------------
>
> Key: CASSANDRA-13703
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13703
> Project: Cassandra
> Issue Type: Bug
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Blocker
> Fix For: 4.x
>
> Attachments: patch
>
>
> This is because chunks written uncompressed end up below the compressed size
> threshold. Demonstrated by applying the attached patch meant to improve the
> testing of the 10520 changes, and running
> {{CompressedSequentialWriterTest.testLZ4Writer}}.
> The default {{min_compress_ratio: 0}} is not affected as it never writes
> uncompressed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
