[ 
https://issues.apache.org/jira/browse/CASSANDRA-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012179#comment-13012179
 ] 

Eric Evans commented on CASSANDRA-2311:
---------------------------------------

This looks OK to me, but I found the name {{validateKeyInColumnFamily}} 
confusing and so changed it to {{validateKeyType}} in the hopes it would make 
things clearer (I won't swear that it does :)).

I also removed the logging statement from the try/catch in the validation 
method, (I assume that was there for debugging purposes).

If you see a problem with either of these two edits, reopen the ticket and/or 
ping me on IRC.

Thanks Jon!

> type validated row keys
> -----------------------
>
>                 Key: CASSANDRA-2311
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2311
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Eric Evans
>            Assignee: Jon Hermes
>              Labels: cql
>             Fix For: 0.8
>
>         Attachments: 2311.txt
>
>
> The idea here is to allow the assignment of a column-family-wide key type 
> used to perform validation, (similar to how default_validation_class does for 
> column values).
> This should be as straightforward as extending the column family schema to 
> include the new attribute, and updating {{ThriftValidation.validateKey}} to 
> validate the key ({{AbstractType.validate}}).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to