[ https://issues.apache.org/jira/browse/CASSANDRA-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211213#comment-16211213 ]
Paulo Motta commented on CASSANDRA-13970: ----------------------------------------- Attaching [patch|https://github.com/pauloricardomg/cassandra/tree/trunk-13970] that implements option a) above. The reason for the compatibility mode was to simplify migration from PFS, but GPFS replaced PFS as the standard snitch and it's it's possible to easily generate a {{cassandra-rackdc.properties}} from a {{cassandra-topology.properties}} if someone is still migrating from PFS to GPFS at this stage, so I don't see a good reason to keep this mode if it can be a source of problems. This doesn't prevent us from doing b) as well, we should also consider moving sample configuration files from the config to an examples directory to prevent them from being loaded without the operator's intent. But we can probably do this in another ticket along with other configuration files. I submitted a test run on internal CI and will post results here when ready. > Remove PFS compatibility mode from GPFS > --------------------------------------- > > Key: CASSANDRA-13970 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13970 > Project: Cassandra > Issue Type: Task > Components: Configuration > Reporter: Paulo Motta > Assignee: Paulo Motta > Priority: Minor > > {{GossipingPropertyFileSnitch}} (GPFS) has a compatibility mode which > fallbacks to {{PropertyFileSnitch}} (PFS) to fetch rack/dc info from > {{conf/cassandra-rackdc.properties}} when a node info is not found in Gossip. > The problem is that we supply a default {{conf/cassandra-rackdc.properties}}, > which is loaded in clusters (as shown in the log below) and may affect ring > layout before gossip settles potentially leading to issues such > CASSANDRA-13948. > {code:none} > INFO [main] 2017-10-12 14:39:32,928 GossipingPropertyFileSnitch.java:64 - > Loaded cassandra-topology.properties for compatibility > {code} > I see 2 options to preven this from causing similar problems in the future: > a) Remove PFS compatibility mode > a) Move {{conf/cassandra-rackdc.properties}} to {{examples}} or > {{conf/examples}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org