[
https://issues.apache.org/jira/browse/CASSANDRA-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213367#comment-16213367
]
Ariel Weisberg commented on CASSANDRA-13123:
--------------------------------------------
The new test that was added doesn't set up it's schema at all. It relies on the
schema created during the previous test. Easy fix there.
The original test (before the new one was added) configures DatabaseDescriptor
before loading the commit log (after which it can't be reloaded). The new test
loads the commit log before this configuration occurs causing the original test
to fail because the commit log configuration is wrong.
If you move the configuration into @BeforeClass the backpressure that is
supposed to be in the original test doesn't occur and the test fails. No
fragile test goes unpunished I guess. I think the might be an interaction with
Byteman that I don't understand.
> Draining a node might fail to delete all inactive commitlogs
> ------------------------------------------------------------
>
> Key: CASSANDRA-13123
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13123
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Jan Urbański
> Assignee: Jan Urbański
> Fix For: 3.0.16, 3.11.2, 4.0
>
> Attachments: 13123-2.2.8.txt, 13123-3.0.10.txt, 13123-3.9.txt,
> 13123-trunk.txt
>
>
> After issuing a drain command, it's possible that not all of the inactive
> commitlogs are removed.
> The drain command shuts down the CommitLog instance, which in turn shuts down
> the CommitLogSegmentManager. This has the effect of discarding any pending
> management tasks it might have, like the removal of inactive commitlogs.
> This in turn leads to an excessive amount of commitlogs being left behind
> after a drain and a lengthy recovery after a restart. With a fleet of dozens
> of nodes, each of them leaving several GB of commitlogs after a drain and
> taking up to two minutes to recover them on restart, the additional time
> required to restart the entire fleet becomes noticeable.
> This problem is not present in 3.x or trunk because of the CLSM rewrite done
> in CASSANDRA-8844.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
