[
https://issues.apache.org/jira/browse/CASSANDRA-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216497#comment-16216497
]
Marcus Eriksson commented on CASSANDRA-13944:
---------------------------------------------
Patch LGTM, but I think the message could be a bit clearer that we don't
support mixed version repairs - not sure "messaging service version" is
something that makes sense to end users. Adding something like "make sure all
nodes involved in the repair are on the same major version" to the message
might help?
> Throw descriptive errors for mixed mode repair attempts
> -------------------------------------------------------
>
> Key: CASSANDRA-13944
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13944
> Project: Cassandra
> Issue Type: Bug
> Components: Repair
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Minor
> Fix For: 4.0
>
>
> We often make breaking changes to streaming and repair between major
> versions, and don't usually support either in mixed mode clusters. Streaming
> connections check protocol versions, but repair message handling doesn't,
> which means cryptic exceptions show up in the logs when operators forget to
> turn off whatever's scheduling repairs on their cluster. Refusing to send or
> receive repair messages to/ from incompatible messaging service versions, and
> throwing a descriptive exception would make it clearer why repair is not
> working, as well as prevent any potentially unexpected behavior.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
