[ https://issues.apache.org/jira/browse/CASSANDRA-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242007#comment-16242007 ]
Aleksey Yeschenko commented on CASSANDRA-13996: ----------------------------------------------- Yeah. I actually saw that and made an explicit call to leave it be, as that close is an obvious no-op, and not having it made the code cleaner. Go ahead if you feel like it, but on principle I'm no fan of make code a bit worse to please tooling or unit tests. Is there an annotation to suppress the warnings instead, maybe? > Close DataInputBuffer in MetadataSerializer > ------------------------------------------- > > Key: CASSANDRA-13996 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13996 > Project: Cassandra > Issue Type: Improvement > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Fix For: 4.x > > > eclipse-warnings complains about this, either introduced by CASSANDRA-13321 > or CASSANDRA-13953 > Patch here: https://github.com/krummas/cassandra/commits/marcuse/closeDIB > https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/416/ > https://circleci.com/gh/krummas/cassandra/170 -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org