[ https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244185#comment-16244185 ]
Stefan Podkowinski commented on CASSANDRA-13997: ------------------------------------------------ I don't think you have to add {{j2objc-annotations}} to the pom (build.xml) as well, as it's already a transitive guava dependency. There are also other dependencies that are [no longer optional|https://github.com/google/guava/commit/0e29934933f33379de953727171f7ca1ec616a58] and not everyone seems to be happy about it. Shouldn't this be reason enough to stick with 23.2 instead for the time being? > Upgrade guava to 23.3 > --------------------- > > Key: CASSANDRA-13997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13997 > Project: Cassandra > Issue Type: Improvement > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Fix For: 4.x > > > For 4.0 we should upgrade guava to the latest version > patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23 > A bunch of quite commonly used methods have been deprecated since guava 18 > which we use now ({{Throwables.propagate}} for example), this patch mostly > updates uses where compilation fails. {{Futures.transform(ListenableFuture > ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for > example, we should probably open new tickets to remove calls to all > deprecated guava methods. > Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to > avoid some build-time warnings (maybe due to > https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d > ?) -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org