[
https://issues.apache.org/jira/browse/CASSANDRA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266832#comment-16266832
]
Marcus Eriksson commented on CASSANDRA-13867:
---------------------------------------------
new patch against trunk up here:
https://github.com/krummas/cassandra/commits/marcuse/13867-trunk-v2
It is a rebase of the 3.0-patch on to trunk with the following
additions/changes:
* remove {{Holder}} from {{PartitionUpdate.Builder}}
* slight optimisation to {{PartitionUpdateCollector}} - collect the partition
updates directly in an {{ImmutableMap.Builder}}
* the mutation builder was basically only used in {{UpdatesCollector}} - moved
the builder and everything related there and refactored the other use case to
not use the builder
* {{UpdatesCollector}} was used in two different ways - one very simple in
{{ModificationStatement}} and one more complicated in {{BatchStatement}} -
extracted an interface and split UpdatesCollector in a
{{SingleTableUpdatesCollector}} and a {{BatchUpdatesCollector}} to be able to
simplify/optimise the single table use case
I had the ambition to also remove {{RowUpdateBuilder}} but I opted not to since
it is now just a test utility class
tests are running here:
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/438/
> Make PartitionUpdate and Mutation immutable
> -------------------------------------------
>
> Key: CASSANDRA-13867
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13867
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> To avoid issues like CASSANDRA-13619 we should make PartitionUpdate and
> Mutation immutable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
