[
https://issues.apache.org/jira/browse/CASSANDRA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267886#comment-16267886
]
Jay Zhuang commented on CASSANDRA-14020:
----------------------------------------
+1 for the change.
But we still need to fix the python style issue:
{noformat}
AssertionError: /Users/zjay/ws/cassandra/bin/cqlsh.py:130:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/bin/cqlsh.py:376:1: E305 expected 2 blank lines after
class or function definition, found 0
/Users/zjay/ws/cassandra/bin/cqlsh.py:2369:17: E722 do not use bare except'
/Users/zjay/ws/cassandra/bin/cqlsh.py:2374:17: E722 do not use bare except'
/Users/zjay/ws/cassandra/bin/cqlsh.py:2433:1: E305 expected 2 blank lines after
class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/copyutil.py:171:13: E722 do not use
bare except'
/Users/zjay/ws/cassandra/pylib/cqlshlib/copyutil.py:225:13: E722 do not use
bare except'
/Users/zjay/ws/cassandra/pylib/cqlshlib/copyutil.py:2150:17: E741 ambiguous
variable name 'l'
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:37:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:146:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:379:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:601:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:611:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:642:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:694:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:854:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:928:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1134:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1153:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1201:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1255:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1318:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1375:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1409:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1558:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/cql3handling.py:1583:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/displaying.py:102:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:48:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:59:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:103:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:211:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:240:1: E305 expected 2
blank lines after class or function definition, found 0
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:262:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:276:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:305:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:315:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:351:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:369:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:479:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:525:1: E305 expected 2
blank lines after class or function definition, found 0
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:551:1: E305 expected 2
blank lines after class or function definition, found 0
/Users/zjay/ws/cassandra/pylib/cqlshlib/formatting.py:584:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/pylexotron.py:521:1: E305 expected 2
blank lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/wcwidth.py:130:1: E305 expected 2 blank
lines after class or function definition, found 1
/Users/zjay/ws/cassandra/pylib/cqlshlib/wcwidth.py:324:1: E305 expected 2 blank
lines after class or function definition, found 1
{noformat}
> test_pep8_compliance - cqlsh_tests.cqlsh_tests.TestCqlsh: pep8 has been
> renamed to pycodestyle (GitHub issue #466)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14020
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Michael Kjellman
>
> test_pep8_compliance - cqlsh_tests.cqlsh_tests.TestCqlsh always fails due to
> us catching a informative warning from the pip8 tool.. looks like we just
> need to swap out the usage
> /home/cassandra/env/local/lib/python2.7/site-packages/pep8.py:2124:
> UserWarning:
> pep8 has been renamed to pycodestyle (GitHub issue #466)
> Use of the pep8 tool will be removed in a future release.
> Please install and use `pycodestyle` instead.
> $ pip install pycodestyle
> $ pycodestyle ...
> '\n\n'
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
