[ https://issues.apache.org/jira/browse/CASSANDRA-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273188#comment-16273188 ]
Jason Brown commented on CASSANDRA-14075: ----------------------------------------- [~mkjellman]'s evaluations is correct: in CASSANDRA-10404, I didn't correctly support pre-4.0 in this dtest. Here is a [dtest patch|https://github.com/jasobrown/cassandra-dtest/tree/14075] that checks the cluster version and only adds the new props if the it's greater than or equal to 4.0. Here are runs of the dtest patch against both 3.11 and trunk: ||3.11||trunk|| |[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14075-3.11]|[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14075-trunk]| || Note: I also ran this locally with jdk1.8.0_151, and started getting this warning: {noformat} Warning: The JKS keystore uses a proprietary format. It is recommended to migrate to PKCS12 which is an industry standard format using "keytool -importkeystore -srckeystore /tmp/tmpICn9py/ca.keystore -destkeystore /tmp/tmpICn9py/ca.keystore -deststoretype pkcs12". {noformat} I've also updated {{sslkeygen.py}} in this patch with a trivial fix to eliminate the warning. > Many sslnodetonode_test.TestNodeToNodeSSLEncryption tests failing with > "Please remove properties [optional, enabled] from your cassandra.yaml" > ---------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-14075 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14075 > Project: Cassandra > Issue Type: Bug > Reporter: Michael Kjellman > Assignee: Jason Brown > > Many sslnodetonode_test.TestNodeToNodeSSLEncryption dtests are failing on > 3.11 with an exception on startup due to invalid yaml properties. > Unexpected error in node1 log, error: > ERROR [main] 2017-11-18 21:01:54,781 CassandraDaemon.java:706 - Exception > encountered during startup: Invalid yaml. Please remove properties [optional, > enabled] from your cassandra.yaml > Although ccm was updated in > https://github.com/pcmanus/ccm/commit/eaaa425b70edb84786924516aee3920d685c0e53 > to include a version check for >= 4.0, enabled and optional are emitted > unconditionally in the actual dtest itself -- they should also be conditional > on >= 4.0 > {code:java} > node.set_configuration_options(values={ > 'server_encryption_options': { > 'enabled': encryption_enabled, > 'optional': encryption_optional, > 'internode_encryption': internode_encryption, > 'keystore': kspath, > 'keystore_password': 'cassandra', > 'truststore': tspath, > 'truststore_password': 'cassandra', > 'require_endpoint_verification': endpoint_verification, > 'require_client_auth': client_auth, > } > }) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org