[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275744#comment-16275744
]
Jay Zhuang edited comment on CASSANDRA-14061 at 12/2/17 8:57 PM:
-----------------------------------------------------------------
I think the warnings are false alert, maybe could add {{iterator.close();}}
here:
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
The warning is introduced in CASSANDRA-13299. cc [~jasonstack]
was (Author: jay.zhuang):
I think the warnings are false alert, maybe we {{iterator.close();}} here:
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
The warning is introduced in CASSANDRA-13299. cc [~jasonstack]
> trunk eclipse-warnings
> ----------------------
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
> Reporter: Jay Zhuang
> Assignee: Jay Zhuang
> Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] ----------
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] ----------
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] ----------
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
