[ https://issues.apache.org/jira/browse/CASSANDRA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331592#comment-16331592 ]
Jay Zhuang commented on CASSANDRA-9067: --------------------------------------- Good points. Thanks [~jasobrown] for the review. Removed the {{oldBfFormat}} serialization and moved it to unittest. Removed {{serialize()}} and {{deserialize()}} in {{FilterFactory}}, updated in the same branch: | Branch | uTest | | [9067|https://github.com/cooldoger/cassandra/tree/9067] | [!https://circleci.com/gh/cooldoger/cassandra/tree/9067.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/9067] | > BloomFilter serialization format should not change byte ordering > ---------------------------------------------------------------- > > Key: CASSANDRA-9067 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9067 > Project: Cassandra > Issue Type: Improvement > Reporter: Benedict > Assignee: Jay Zhuang > Priority: Minor > Fix For: 4.x > > > As a follow-up to CASSANDRA-9066 and CASSANDRA-9060, it appears we do some > unnecessary byte swapping during the serialization of bloom filters, which > makes the logic slower and harder to follow. We should either perform them > more efficiently (using Long.reverseBytes) or, preferably, eliminate the > conversion altogether since it does not appear to serve any purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org