[
https://issues.apache.org/jira/browse/CASSANDRA-14092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348437#comment-16348437
]
Sam Tunnicliffe commented on CASSANDRA-14092:
---------------------------------------------
Sounds good to me. Reject and optionally cap at input time, plus a offline
route to full recovery (if possible & desired) via scrub sounds like the best
way forward IMO. I'll do a full review when you have the cleaned up patches
ready, but the WIP branches generally LGTM at first glance. The wording of the
NEWS.txt entry is good, I do wonder if we should maybe place it right at the
top of the file rather than just in the 3.0.16 section for extra emphasis. Any
thoughts on that?
I also have one piece of feedback on the policies; I don't see any benefit in
being able to turn off logging of capped expirations (especially since we're
using NoSpamLogger) but I do I think the client warning is useful. So I would
change the policies to:
{noformat}
- REJECT (default and as you've defined it)
- CAP (cap, log and issue client warning)
- CAP_NOWARN (cap and log)
{noformat}
I also noticed that the logging of a parse error/invalid value for the policy
sysprop is at DEBUG in the current patches, but it might be sensible to draw a
bit more attention to that if it happens.
> Max ttl of 20 years will overflow localDeletionTime
> ---------------------------------------------------
>
> Key: CASSANDRA-14092
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14092
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Priority: Blocker
> Fix For: 2.1.20, 2.2.12, 3.0.16, 3.11.2
>
>
> CASSANDRA-4771 added a max value of 20 years for ttl to protect against [year
> 2038 overflow bug|https://en.wikipedia.org/wiki/Year_2038_problem] for
> {{localDeletionTime}}.
> It turns out that next year the {{localDeletionTime}} will start overflowing
> with the maximum ttl of 20 years ({{System.currentTimeMillis() + ttl(20
> years) > Integer.MAX_VALUE}}), so we should remove this limitation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
