[ https://issues.apache.org/jira/browse/CASSANDRA-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349207#comment-16349207 ]
Andrés de la Peña commented on CASSANDRA-14205: ----------------------------------------------- Thanks for the review! Committed to cassandra-3.11 as [6b00767427706124e016e4f471c2266899387163|https://github.com/apache/cassandra/commit/6b00767427706124e016e4f471c2266899387163] and merged to trunk. > ReservedKeywords class is missing some reserved CQL keywords > ------------------------------------------------------------ > > Key: CASSANDRA-14205 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14205 > Project: Cassandra > Issue Type: Bug > Components: CQL > Reporter: Andrés de la Peña > Assignee: Andrés de la Peña > Priority: Major > Fix For: 3.11.x, 4.x > > > The CQL keywords {{DEFAULT}}, {{UNSET}}, {{MBEAN}} and {{MBEANS}} (introduced > by CASSANDRA-11424 and CASSANDRA-10091) are neither considered [unreserved > keywords|https://github.com/apache/cassandra/blob/trunk/src/antlr/Parser.g#L1788-L1846] > by the ANTLR parser, nor included in the > [{{ReservedKeywords}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/ReservedKeywords.java] > class. > The current parser behaviour is considering them as reserved keywords, in the > sense that they can't be used as keyspace/table/column names, which seems > right: > {code:java} > cassandra@cqlsh> CREATE KEYSPACE unset WITH replication = {'class': > 'SimpleStrategy', 'replication_factor': 1}; > SyntaxException: line 1:16 no viable alternative at input 'unset' (CREATE > KEYSPACE [unset]...) > {code} > I think we should keep considering these keywords as reserved and add them to > {{ReservedKeywords}} class. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org