[ 
https://issues.apache.org/jira/browse/CASSANDRA-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349548#comment-16349548
 ] 

Jason Brown commented on CASSANDRA-13665:
-----------------------------------------

Thanks for the patch. Overall it looks fine, but a few things:
 - in {{NativeTransportService}}, you've changed the metric type for 
{{connectedNativeClients}} from a counter to a gauge. Why? will this break 
existing tooling?

nits:
 - NodeProbe - when you hit the {{default}} case, please log the metric name 
that was not found
 - ClientStats - missing apache license header
 - Server - replace the {{""+conn.getVersion().asInt()}} string conversion to 
{{String.valueOf()}}
 - {{CassandraDaemon}} - {{getNativeTransportService()}} doesn't seem to be 
used anywhere. Should it be deleted?

> nodetool clientlist
> -------------------
>
>                 Key: CASSANDRA-13665
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13665
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jon Haddad
>            Assignee: Chris Lohfink
>            Priority: Major
>
> There should exist a nodetool command that lists each client connection. 
> Ideally it would display the following:
>  * host
>  * protocol version
>  * user logged in as
>  * current keyspace
>  * total queries executed
>  * ssl connections



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to