Count deleted rows scanned during reads for tracing and warning tombstone thresholds.
If a row is read but is not live anymore (which happens with row level tombstones) it is not counted anywhere in the metrics nor reported in tracing. Row tombstones themselves are not reported anywhere. The consequence is that some delete heavy workloads will show no tombstone read but endure severe performance issues. This commit counts deleted rows as standard tombstone cells. Patch by Alexander Dejanovski; Reviewed by Jon Haddad for CASSANDRA-8527 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b2d20d4b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b2d20d4b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b2d20d4b Branch: refs/heads/trunk Commit: b2d20d4bb10e73935a97d6fbd848e4cb649c105c Parents: 0f58f6c 419552a Author: Jon Haddad <j...@jonhaddad.com> Authored: Thu Feb 8 10:50:14 2018 -0800 Committer: Jon Haddad <j...@jonhaddad.com> Committed: Thu Feb 8 10:50:14 2018 -0800 ---------------------------------------------------------------------- CHANGES.txt | 1 + .../org/apache/cassandra/db/ReadCommand.java | 26 ++- .../apache/cassandra/metrics/TableMetrics.java | 2 +- .../apache/cassandra/db/ReadCommandTest.java | 169 +++++++++++++++++++ 4 files changed, 192 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b2d20d4b/CHANGES.txt ---------------------------------------------------------------------- diff --cc CHANGES.txt index 191caaf,bc2645f..c7c1b6f --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -186,6 -174,6 +186,7 @@@ * Switch to client init for sstabledump (CASSANDRA-13683) * CQLSH: Don't pause when capturing data (CASSANDRA-13743) * nodetool clearsnapshot requires --all to clear all snapshots (CASSANDRA-13391) ++ * Correctly count range tombstones in traces and tombstone thresholds (CASSANDRA-8527) 3.11.2 http://git-wip-us.apache.org/repos/asf/cassandra/blob/b2d20d4b/test/unit/org/apache/cassandra/db/ReadCommandTest.java ---------------------------------------------------------------------- --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
