[ https://issues.apache.org/jira/browse/CASSANDRA-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386664#comment-16386664 ]
Jason Brown commented on CASSANDRA-14194: ----------------------------------------- bq. #2 This won't happen because LockSupport.unpark() will cause it to wake immediately I believe? Reading the docs you linked, this sounds correct. I will remove that change on commit. (thanks! this was a good pointer) > Chain commit log marker potential performance regression in batch commit mode > ----------------------------------------------------------------------------- > > Key: CASSANDRA-14194 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14194 > Project: Cassandra > Issue Type: Bug > Components: Core, Testing > Reporter: Ariel Weisberg > Assignee: Jason Brown > Priority: Major > Fix For: 3.0.x, 3.11.x, 4.x > > Attachments: jstack.txt > > > CASSANDRA-13987 modified how the commit log sync thread works. I noticed that > cql3.ViewTest and ViewBuilderTaskTest have been timing out, but only in > CircleCI. When I jstack in CircleCI what I see is that the commit log writer > thread is parked and the threads trying to append to the commit log are > blocked waiting on it. > I tested the commit before 13987 and it passed in CircleCI and then I tested > with 13987 and it timed out. I suspect this may be a general performance > regression and not just a CircleCI issue. > And this is with write barriers disabled (sync thread doesn't actually sync) > so it wasn't blocked in the filesystem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org