[ 
https://issues.apache.org/jira/browse/CASSANDRA-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404307#comment-16404307
 ] 

Jon Haddad commented on CASSANDRA-13853:
----------------------------------------

Just looked at the patch.  Overall, it looks good, I just have a small nit - 
the RF reported under the datacenters section is a little misleading.  

I created a 2 DC cluster with 2 keyspaces:

{code}
cqlsh> create KEYSPACE whatever WITH replication = {'class': 
'NetworkTopologyStrategy', 'dc1': 3, 'dc2':5};
cqlsh> create KEYSPACE whatever2 WITH replication = {'class': 
'NetworkTopologyStrategy', 'dc1': 3, 'dc2':5};
{code}

The keyspaces section from the output of nodetool reports RF=8, which is a 
little odd.  I'd expect to see each of the DCs listed with their own RFs.  

{code}
Keyspaces:
        system_schema RF: 1
        system RF: 1
        system_traces RF: 2
        system_distributed RF: 3
        system_auth RF: 1
        whatever RF: 8
        whatever2 RF: 8
{code}

Mind changing the output to include the replication class & options?  

> nodetool describecluster should be more informative
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13853
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13853
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability, Tools
>            Reporter: Jon Haddad
>            Assignee: Preetika Tyagi
>            Priority: Minor
>              Labels: lhf
>             Fix For: 4.x
>
>         Attachments: cassandra-13853.patch
>
>
> Additional information we should be displaying:
> * Total node count
> * List of datacenters, RF, with number of nodes per dc, how many are down, 
> * Version(s)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to