[ https://issues.apache.org/jira/browse/CASSANDRA-14338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411405#comment-16411405 ]
Aleksey Yeschenko commented on CASSANDRA-14338: ----------------------------------------------- Good call. I'd say in 3.0 this also should be fixed, so that a single exception there doesn't stop recalculating percentiles for the affected table. Thanks for the review. Will commit once Circle is happy. > Fix scheduling of speculative retry threshold recalculation > ----------------------------------------------------------- > > Key: CASSANDRA-14338 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14338 > Project: Cassandra > Issue Type: Bug > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Major > Fix For: 4.0 > > > Realized after committing CASSANDRA-14293 that it's slightly broken: when > updating from a static to a dynamic speculative retry policy, the refresher > will never be scheduled. > Also realised that the whole thing is a bit dumb. We don't need a latency > calculator runnable per {{ColumnFamilyStore}}, we should have one per node, > that does in batch refresh thresholds for every table. It's one fewer thing > to manage, and allows to get rid of {{isDynamic()}} method in > {{SpeculativeRetryPolicy}}, which I thought was clever at the time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org