[
https://issues.apache.org/jira/browse/CASSANDRA-13853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431325#comment-16431325
]
Ariel Weisberg commented on CASSANDRA-13853:
--------------------------------------------
I just realized you can simplify things a little. You don't need to respect the
withPort for fields that you add to describe cluster. You can default it to
true for anything you add and always include port information. Anyone using
this new output has to write new automation anyways so they can handle the port
being present.
It's actually important to provide ports all the time because it prevents
people from writing new automation against an ambiguous identifier
The loop checking for unreachable nodes is introducing ambiguity by extracting
host address. Extracting a host address from an InetAddressAndPort is almost
always wrong because it doesn't uniquely identify anything. Use toString() on
the InetAddressAndPort so it matches the string representation by the server.
> nodetool describecluster should be more informative
> ---------------------------------------------------
>
> Key: CASSANDRA-13853
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13853
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability, Tools
> Reporter: Jon Haddad
> Assignee: Preetika Tyagi
> Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: cassandra-13853-v2.patch, cassandra-13853-v3.patch,
> cassandra-13853-v4.patch, nodetool_describecluster_test.py
>
>
> Additional information we should be displaying:
> * Total node count
> * List of datacenters, RF, with number of nodes per dc, how many are down,
> * Version(s)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
