Repository: cassandra-dtest Updated Branches: refs/heads/master 6edfe7fb5 -> 2ee611a6d
Add tests for running shadow round using seeds and/or peers Patch by Kurt Greaves; reveiewd by Sam Tunnicliffe for CASSANDRA-13851 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/2ee611a6 Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/2ee611a6 Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/2ee611a6 Branch: refs/heads/master Commit: 2ee611a6d2bf5090d52856c7bc2368a2dc37f153 Parents: 6edfe7f Author: kurt <k...@instaclustr.com> Authored: Wed Nov 1 09:57:10 2017 +0000 Committer: Sam Tunnicliffe <s...@beobal.com> Committed: Tue Apr 17 18:22:04 2018 +0100 ---------------------------------------------------------------------- dtest.py | 13 +++++++ seed_test.py | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/2ee611a6/dtest.py ---------------------------------------------------------------------- diff --git a/dtest.py b/dtest.py index 914f2f7..2aa30b8 100644 --- a/dtest.py +++ b/dtest.py @@ -276,6 +276,19 @@ class Tester: runner.start() return runner + def assert_log_had_msg(self, node, msg, timeout=600, **kwargs): + """ + Wrapper for ccmlib.node.Node#watch_log_for to cause an assertion failure when a log message isn't found + within the timeout. + :param node: Node which logs we should watch + :param msg: String message we expect to see in the logs. + :param timeout: Seconds to wait for msg to appear + """ + try: + node.watch_log_for(msg, timeout=timeout, **kwargs) + except TimeoutError: + pytest.fail("Log message was not seen within timeout:\n{0}".format(msg)) + def get_eager_protocol_version(cassandra_version): """ Returns the highest protocol version accepted http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/2ee611a6/seed_test.py ---------------------------------------------------------------------- diff --git a/seed_test.py b/seed_test.py new file mode 100644 index 0000000..1f00d8b --- /dev/null +++ b/seed_test.py @@ -0,0 +1,109 @@ +from ccmlib import node +from dtest import Tester +from time import sleep + +import pytest + +since = pytest.mark.since + + +class TestGossiper(Tester): + """ + Test gossip states + """ + + @since('3.11.2') + def test_startup_no_live_seeds(self): + """ + Test that a node won't start with no live seeds. + @jira_ticket CASSANDRA-13851 + """ + + self.fixture_dtest_setup.allow_log_errors = True + n1 = self.cluster.create_node('node1', True, None, ('127.0.0.1', 7000), '7100', + None, None, binary_interface=('127.0.0.1', 9042)) + self.cluster.add(n1, False) + node1 = self.cluster.nodelist()[0] + self.cluster.set_configuration_options({ + 'seed_provider': [{'class_name': 'org.apache.cassandra.locator.SimpleSeedProvider', + 'parameters': [{'seeds': '127.0.0.2'}] # dummy node doesn't exist + }] + }) + + try: + STARTUP_TIMEOUT = 15 # seconds + RING_DELAY = 10000 # ms + # set startup timeout > ring delay so that startup failure happens before the call to start returns + node1.start(wait_for_binary_proto=STARTUP_TIMEOUT, jvm_args=['-Dcassandra.ring_delay_ms={}'.format(RING_DELAY)]) + except node.TimeoutError: + self.assert_log_had_msg(node1, "Unable to gossip with any peers") + except Exception as e: + raise e + else: + pytest.fail("Expecting startup to raise a TimeoutError, but nothing was raised.") + + @since('3.11.2') + def test_startup_non_seed_with_peers(self): + """ + Test that a node can start if peers are alive, or if a node has been bootstrapped + but there are no live seeds or peers + @jira_ticket CASSANDRA-13851 + """ + + self.fixture_dtest_setup.allow_log_errors = True + + n1 = self.cluster.create_node('node1', True, None, ('127.0.0.1', 7000), '7100', + None, None, binary_interface=('127.0.0.1', 9042)) + n2 = self.cluster.create_node('node2', True, None, ('127.0.0.2', 7000), '7101', + None, None, binary_interface=('127.0.0.2', 9042)) + n3 = self.cluster.create_node('node3', True, None, ('127.0.0.3', 7000), '7102', + None, None, binary_interface=('127.0.0.3', 9042)) + self.cluster.add(n1, True) + self.cluster.add(n2, True) + self.cluster.add(n3, True) + + node1, node2, node3 = self.cluster.nodelist() + + self.cluster.start() + node3.stop(wait=True) + node1.stop(wait=True) + self.cluster.set_configuration_options({ + 'seed_provider': [{'class_name': 'org.apache.cassandra.locator.SimpleSeedProvider', + 'parameters': [{'seeds': '127.0.0.1'}] + }] + }) + + # test non seed node can start when peer is started but seed isn't + node3.start(wait_other_notice=False, wait_for_binary_proto=120) + self.assert_log_had_msg(node3, "Received an ack from {}, who isn't a seed. Ensure your seed list includes a live node. Exiting shadow round".format(node2.address_for_current_version_slashy()), timeout=60) + node2.stop(wait=False) + node3.stop(wait=True) + + # test seed node starts when no other nodes started + node1.start(wait_other_notice=False, wait_for_binary_proto=120) + self.assert_log_had_msg(node1, 'Unable to gossip with any peers but continuing anyway since node is in its own seed list', timeout=60) + + @since('3.11.2') + def test_startup_after_ring_delay(self): + """ + Tests that if we start a node with no live seeds, then start a seed after RING_DELAY + we will still join the ring. More broadly tests that starting a seed while a node is in + shadow round will still allow that node to join the ring. + @jira_ticket CASSANDRA-13851 + """ + RING_DELAY = 15000 # ms + self.fixture_dtest_setup.allow_log_errors = True + n1 = self.cluster.create_node('node1', True, None, ('127.0.0.1', 7000), '7100', + None, None, binary_interface=('127.0.0.1', 9042)) + n2 = self.cluster.create_node('node2', True, None, ('127.0.0.2', 7000), '7101', + None, None, binary_interface=('127.0.0.2', 9042)) + self.cluster.add(n1, True) + self.cluster.add(n2, False) + node1, node2 = self.cluster.nodelist() + + node2.start(wait_other_notice=False, jvm_args=['-Dcassandra.ring_delay_ms={}'.format(RING_DELAY)]) + node2.watch_log_for('Starting shadow gossip round to check for endpoint collision', filename='debug.log') + sleep(RING_DELAY / 1000) + # Start seed, ensure node2 joins before it exits shadow round. + node1.start(wait_other_notice=True, wait_for_binary_proto=120) + self.assert_log_had_msg(node2, 'Starting listening for CQL clients', timeout=60) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
