[ 
https://issues.apache.org/jira/browse/CASSANDRA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444942#comment-16444942
 ] 

Blake Eggleston edited comment on CASSANDRA-14346 at 4/19/18 10:56 PM:
-----------------------------------------------------------------------

bq. The scheduler right now just uses the ActiveRepairService thread pool to 
see if Cassandra is running repairs

I'm pretty sure that's not going to work in trunk. Repair was made async in 
3.0. As of 4.0 it doesn't even block on validation, so the threadpool isn't 
going give you any valuable information.

bq. I'm not sure of the state of incremental + subrange, is it fixed in trunk? 

Incremental repair and incremental repair + subrange is fixed in trunk, but you 
really shouldn't do subrange incremental repairs unless you have a really good 
reason, since you'll do a lot of additional anti-compaction. Anyway, as long as 
you're running incremental repair regularly, you should be able to repair full 
token ranges in less than 30 min.


was (Author: bdeggleston):
bq. The scheduler right now just uses the ActiveRepairService thread pool to 
see if Cassandra is running repairs

I'm pretty sure that's not going to work in trunk. Repair was made async in 
3.0. As of 4.0 it doesn't even block on validation, so the threadpool isn't 
going give you any valuable information.

bq. I'm not sure of the state of incremental + subrange, is it fixed in trunk? 

Incremental repair and incremental repair + subrange is fixed in trunk, but you 
really shouldn't do subrange repairs unless you have a really good reason, 
since you'll do a lot of additional anti-compaction. Anyway, as long as you're 
running incremental repair regularly, you should be able to repair full token 
ranges in less than 30 min.

> Scheduled Repair in Cassandra
> -----------------------------
>
>                 Key: CASSANDRA-14346
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14346
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Repair
>            Reporter: Joseph Lynch
>            Priority: Major
>              Labels: CommunityFeedbackRequested
>             Fix For: 4.0
>
>         Attachments: ScheduledRepairV1_20180327.pdf
>
>
> There have been many attempts to automate repair in Cassandra, which makes 
> sense given that it is necessary to give our users eventual consistency. Most 
> recently CASSANDRA-10070, CASSANDRA-8911 and CASSANDRA-13924 have all looked 
> for ways to solve this problem.
> At Netflix we've built a scheduled repair service within Priam (our sidecar), 
> which we spoke about last year at NGCC. Given the positive feedback at NGCC 
> we focussed on getting it production ready and have now been using it in 
> production to repair hundreds of clusters, tens of thousands of nodes, and 
> petabytes of data for the past six months. Also based on feedback at NGCC we 
> have invested effort in figuring out how to integrate this natively into 
> Cassandra rather than open sourcing it as an external service (e.g. in Priam).
> As such, [~vinaykumarcse] and I would like to re-work and merge our 
> implementation into Cassandra, and have created a [design 
> document|https://docs.google.com/document/d/1RV4rOrG1gwlD5IljmrIq_t45rz7H3xs9GbFSEyGzEtM/edit?usp=sharing]
>  showing how we plan to make it happen, including the the user interface.
> As we work on the code migration from Priam to Cassandra, any feedback would 
> be greatly appreciated about the interface or v1 implementation features. I 
> have tried to call out in the document features which we explicitly consider 
> future work (as well as a path forward to implement them in the future) 
> because I would very much like to get this done before the 4.0 merge window 
> closes, and to do that I think aggressively pruning scope is going to be a 
> necessity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to