[
https://issues.apache.org/jira/browse/CASSANDRA-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446271#comment-16446271
]
Jason Brown edited comment on CASSANDRA-12151 at 4/20/18 7:46 PM:
------------------------------------------------------------------
Thanks to [~djoshi3] and [~spo...@gmail.com] for doing the first passes of
review here, I'll take it the rest of the way.
[~vinaykumarcse] and I spoke offline about some things, and on the whole we are
in the right direction. As I started reviewing the patch, the whitespace
inconsistencies nagged at me, so I went ahead and fixed those, as well as some
random code comments. Further, I made {{AuditLogFilters}} atomic and final, and
no longer a singleton; a volatile reference is maintained in
{{AuditLogManager}}. I also moved getLogEntry methods from {{AuditLogManager}}
to {{AuditLogEntry}} as they seemed more apropos there. Code available
[here|https://github.com/jasobrown/cassandra/tree/trunk_CASSANDRA-12151].
(Note: i didn't run the tests, so you may need to fix those up if necessary)
There are some things wrt the interaction of FQL and AuditLogging that I still
need to work out in my head, and I've asked Vinay to add some nodetool commands
for enabling/disabling auditlog as well (or, at least, to seriously think about
it). However, I wanted to post that first batch of changes to get that out of
the way.
was (Author: jasobrown):
Thanks to [~djoshi3] and [~spo...@gmail.com] for doing the first passes of
review here, I'll take it the rest of the way.
[~vinaykumarcse] and I spoke offline about some things, and on the whole we are
in the right direction. As I started reviewing the patch, the whitespace
inconsistencies nagged at me, so I went ahead and fixed those, as well as some
random code comments. Further, I made {{AuditLogFilters}} atomic and final, and
no longer a singleton; a volatile reference is maintained in
{{AuditLogManager}}. I also moved getLogEntry methods from {{AuditLogManager}}
to {{AuditLogEntry}} as they seemed more apropos there. Code available
[here|https://github.com/jasobrown/cassandra/tree/trunk_CASSANDRA-12151].
There are some things wrt the interaction of FQL and AuditLogging that I still
need to work out in my head, and I've asked Vinay to add some nodetool commands
for enabling/disabling auditlog as well (or, at least, to seriously think about
it). However, I wanted to post that first batch of changes to get that out of
the way.
> Audit logging for database activity
> -----------------------------------
>
> Key: CASSANDRA-12151
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12151
> Project: Cassandra
> Issue Type: New Feature
> Reporter: stefan setyadi
> Assignee: Vinay Chella
> Priority: Major
> Fix For: 4.x
>
> Attachments: 12151.txt, CASSANDRA_12151-benchmark.html,
> DesignProposal_AuditingFeature_ApacheCassandra_v1.docx
>
>
> we would like a way to enable cassandra to log database activity being done
> on our server.
> It should show username, remote address, timestamp, action type, keyspace,
> column family, and the query statement.
> it should also be able to log connection attempt and changes to the
> user/roles.
> I was thinking of making a new keyspace and insert an entry for every
> activity that occurs.
> Then It would be possible to query for specific activity or a query targeting
> a specific keyspace and column family.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
