[ 
https://issues.apache.org/jira/browse/CASSANDRA-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446288#comment-16446288
 ] 

Jason Brown edited comment on CASSANDRA-14389 at 4/20/18 8:02 PM:
------------------------------------------------------------------

[~djoshi3], This looks pretty good. However, I wonder if we can dump all the 
places where we naively plumb the 'connecting' address though. I took a pass at 
it here:

||14389||
|[branch|https://github.com/jasobrown/cassandra/tree/14389]|
|[utests & 
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14389]|
||

The only change of interest is in 
{{MessagingService#getPreferredRemoteAddr()}}, I check into 
{{SystemKeyspace.getPreferredIP(to)}} if there was no {{OutboundMessagingPool}} 
set up in {[MessagingService#channelManagers}}. wdyt?


was (Author: jasobrown):
@Dniesh, This looks pretty good. However, I wonder if we can dump all the 
places where we naively plumb the 'connecting' address though. I took a pass at 
it here:

||14389||
|[branch|https://github.com/jasobrown/cassandra/tree/14389]|
|[utests & 
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14389]|
||

The only change of interest is in 
{{MessagingService#getPreferredRemoteAddr()}}, I check into 
{{SystemKeyspace.getPreferredIP(to)}} if there was no {{OutboundMessagingPool}} 
set up in {[MessagingService#channelManagers}}. wdyt?

> Resolve local address binding in 4.0
> ------------------------------------
>
>                 Key: CASSANDRA-14389
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14389
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jason Brown
>            Assignee: Dinesh Joshi
>            Priority: Minor
>             Fix For: 4.x
>
>
> CASSANDRA-8457/CASSANDRA-12229 introduced a regression against 
> CASSANDRA-12673. This was discovered with CASSANDRA-14362 and moved here for 
> resolution independent of that ticket.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to