[
https://issues.apache.org/jira/browse/CASSANDRA-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446874#comment-16446874
]
Jason Brown commented on CASSANDRA-14389:
-----------------------------------------
I didn't understand the {{NettyStreamingMessageSenderFactory}} and subclassing
of {{NettyStreamingMessageSender}} in the {{StreamSessionTest}}. You weren't
really taking any advantage of the subclass as all {{NSMSStub}} did was
override the parent's constructor, only to call the parent's constructor. Thus
I've removed {{NettyStreamingMessageSenderFactory}} (ignore the comment on the
commit) and cleaned up the test. I've pushed up a commit to my branch, on top
of your squash, and ran the testa again. If you are good with that, I'm +1 on
the rest of the patch.
> Resolve local address binding in 4.0
> ------------------------------------
>
> Key: CASSANDRA-14389
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14389
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jason Brown
> Assignee: Dinesh Joshi
> Priority: Minor
> Fix For: 4.x
>
>
> CASSANDRA-8457/CASSANDRA-12229 introduced a regression against
> CASSANDRA-12673. This was discovered with CASSANDRA-14362 and moved here for
> resolution independent of that ticket.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
