[ https://issues.apache.org/jira/browse/CASSANDRA-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018065#comment-13018065 ]
Sylvain Lebresne commented on CASSANDRA-2440: --------------------------------------------- bq. Could we perhaps also merge CounterSuperColumn with SuperColumn by giving SuperColumn two lists? I could see pros and cons for that. The cons for instance would be that with the patch as is, the COSC structure has a kind of nice symmetry (normal columm and sc/counter column and sc). In particular the distinction for counter/standard is done at the same 'level' (the COSC leve) which could maybe be a little simpler for client. Lastly, I'm more reluctant to make field of SuperColumn optional while Mutation already has all of its field optional. Anyway I guess I don't really care so much one way or another. The main point was to remove all the duplicate API calls. But since I think I have a tiny preference for how it is right now, I'd be willing to be lazy and leave it at that unless there is strong feelings expressed for doing otherwise. > Merge ColumnOrSuperColumn and Counter thrift structure to avoid most of the > counter API call duplication > -------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-2440 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2440 > Project: Cassandra > Issue Type: Improvement > Components: API > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 0.8 > > Attachments: cassandra.thrift > > Original Estimate: 8h > Remaining Estimate: 8h > > Having duplicate calls for all counter operation is ugly. Distinguishing a > Column from a CounterColumn is a good idea, but I feel we went too far in > making counters an API on its own. This ticket proposes to merge the Counter > and ColumnOrSuperColumn thrift structure (while keeping CounterColumn and > CounterSuperColumn) and to remove all the duplicate API calls. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira