[ 
https://issues.apache.org/jira/browse/CASSANDRA-14416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452398#comment-16452398
 ] 

Sam Tunnicliffe commented on CASSANDRA-14416:
---------------------------------------------

Looks like the dtest changes for CASSANDRA-13985 missed one place where it 
needs to consider the C* version. I'll push a fix in a minute & you can re-run 
the tests.

> Remove string formatting lines from hot path
> --------------------------------------------
>
>                 Key: CASSANDRA-14416
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14416
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.11.x, 4.x
>
>
> In the BufferPool, we have a {{NoSpamLogger}} that gets called in some 
> conditions (like when we're at or near the cap in a given pool), which has 
> some string formatting on it. In situations where that log line is invoked, 
> that string formatting gets called before the rate limiting, which becomes 
> expensive. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to