[
https://issues.apache.org/jira/browse/CASSANDRA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453415#comment-16453415
]
Dinesh Joshi commented on CASSANDRA-14360:
------------------------------------------
Hi [~cnlwsu], your patch looks good. There are only a couple minor things -
# {{StorageService#samplePartitions}} - You can get rid of the type parameters
(new HashMap<Sampler, CompositeData>() -> new HashMap<>())
# {{StorageService#samplePartitions}} - Could you please enclose the for loops
on line 5230 and 5237 in a block?
# {{StorageService#getPartitionSample}} - Please fix spacing on line 436
# {{TopPartitions#execute}} - Please fix spacing on line 110
It would be nice if you could please include a unit test for
{{StorageService#samplePartitions}}.
> Allow nodetool toppartitions without specifying table
> -----------------------------------------------------
>
> Key: CASSANDRA-14360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14360
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Chris Lohfink
> Assignee: Chris Lohfink
> Priority: Major
>
> It can be hard to determine even which table is the one with most issue, so
> determining if there is a single dominate partition being updated or queried
> would be nicer without having to specify the table.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
