[
https://issues.apache.org/jira/browse/CASSANDRA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476600#comment-16476600
]
Jordan West edited comment on CASSANDRA-14417 at 5/16/18 3:59 AM:
------------------------------------------------------------------
* The output when {{extended=false}}, {{checkOwnsTokens=true}} is still debug
(because the message was removed and the exception is logged as debug). I see
it changed when extended=true. Verifier#L217.
* While cleaning things up, should
{{ColumnFamilyStore#findBestDiskAndInvalidateCaches}} be refactored to use
{{KeyIterator}} as well?
* EDIT: Also, just noticed the failing dtest. Seems to be in an area
related-ish to these changes but I am not familiar enough with it yet to know
if its related or just a flaky test. (EDIT: it failed here on a branch without
this change https://circleci.com/gh/jrwest/cassandra/86#tests/containers/66)
was (Author: jrwest):
* The output when {{extended=false}}, {{checkOwnsTokens=true}} is still debug
(because the message was removed and the exception is logged as debug). I see
it changed when extended=true. Verifier#L217.
* While cleaning things up, should
{{ColumnFamilyStore#findBestDiskAndInvalidateCaches}} be refactored to use
{{KeyIterator}} as well?
* EDIT: Also, just noticed the failing dtest. Seems to be in an area
related-ish to these changes but I am not familiar enough with it yet to know
if its related or just a flaky test.
> nodetool import cleanup/fixes
> -----------------------------
>
> Key: CASSANDRA-14417
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14417
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Fix For: 4.x
>
>
> * We shouldn't expose importNewSSTables in both StorageServiceMBean and
> CFSMbean
> * Allow a quicker token check without doing an extended verify
> * Introduce an ImportOptions class to avoid passing in 100 booleans in
> importNewSSTables
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
