[
https://issues.apache.org/jira/browse/CASSANDRA-14447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478087#comment-16478087
]
Jason Brown commented on CASSANDRA-14447:
-----------------------------------------
Linked branches for changes to 3.0/3.11/trunk:
||3.0||3.11||trunk||
|[branch|https://github.com/jasobrown/cassandra/tree/14447-3.0]|[branch|https://github.com/jasobrown/cassandra/tree/14447-3.11]|[branch|https://github.com/jasobrown/cassandra/tree/14447-trunk]|
|[utests &
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14447-3.0]|[utests
&
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14447-3.11]|[utests
&
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14447-trunk]|
Changes to 3.0 & 3.11:
- add PING verb and {{PingMessage}}, with an {{IVersionedSerializer}} The
serializer is important so we can correctly deserialize the message, but we
will ignore it (no need to back port all the functionality around
{{StartupClusterConnectivityChecker}}).
Changes to 4.0:
- reworked {{StartupClusterConnectivityChecker}} to be event based, rather
than polling and sleeping.
- future-proof {{MessageIn}} and {{MessageDeliveryTask}} to ignore unknown
messages, but also to skip the payload bytes of the message (to leave the
stream in a clean state).
- rewrote {{StartupClusterConnectivityCheckerTest}}, and made on minor class
visibility changes in {{o.a.c.gms}} to enable more sane testing.
> Cleanup StartupClusterConnectivityChecker and PING Verb
> -------------------------------------------------------
>
> Key: CASSANDRA-14447
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14447
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jason Brown
> Assignee: Jason Brown
> Priority: Minor
> Fix For: 3.0.x, 3.11.x, 4.0.x
>
>
> This is a followup to CASSANDRA-13993. After an internal review,
> [~iamaleksey] had some concerns wrt to the VERB choices as was committed;
> this was discussed on CASSANDRA-13993, after commit. Further, he pointed out
> (and provided) some optimizations for {{StartupClusterConnectivityChecker}}
> itself. While testing some of the proposed changes, I also discovered a small
> bug where the timeout for waiting for the response to the PING message was
> dramtically shorter than the overall timeout that is configured for
> {{StartupClusterConnectivityChecker}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
