[ https://issues.apache.org/jira/browse/CASSANDRA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan West updated CASSANDRA-14207: ------------------------------------ Attachment: 14207-example-test.patch Reproduced In: 3.11.1, 3.11.0 (was: 3.11.0, 3.11.1) Status: Patch Available (was: Open) I've worked up a patch for this that applies to 3.11: [https://github.com/jrwest/cassandra/commits/14207-3.11.] The patch applies cleanly to trunk last I tested. Ran tests on [3.11|https://circleci.com/gh/jrwest/cassandra/tree/14207-3%2E11] and on [trunk|https://circleci.com/gh/jrwest/cassandra/tree/14207-trunk]. Also, attached is a test that I don't think is worth merging (its too contrived) but is illustrative of the scenario that causes a double release to occur. [~ifesdjeen] would you be able to take a look? > Failed Compare and Swap in SASI's DataTracker#update Can Lead to Improper > Reference Counting of SSTableIndex > ------------------------------------------------------------------------------------------------------------ > > Key: CASSANDRA-14207 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14207 > Project: Cassandra > Issue Type: Bug > Components: sasi > Reporter: Jordan West > Assignee: Jordan West > Priority: Major > Attachments: 14207-example-test.patch, > sasi-invalid-reference-count.rtf > > > A race between e.g. Index Redistribution and Compaction can cause the compare > and swap of a new {{sasi.conf.View}} in {{sasi.conf.DataTracker#update}} to > fail, leading to recreation of the view and improper reference counting of an > {{SSTableIndex}}. This is because the side-effects (decrementing the > reference count via {{SStableIndex#release}}) occur regardless of if the view > is promoted to be the active view. > Code: > https://github.com/apache/cassandra/blob/cassandra-3.11.1/src/java/org/apache/cassandra/index/sasi/conf/DataTracker.java#L72-L78 > > Attached logs and debug output show case where index redistribution and > compaction race. This case was generated using the test provided in > https://issues.apache.org/jira/browse/CASSANDRA-14055 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org