[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494696#comment-16494696
]
Jay Zhuang edited comment on CASSANDRA-14422 at 5/30/18 5:18 AM:
-----------------------------------------------------------------
Sure, I split the change for easy review:
||Diff||
|[14422-3.0|https://github.com/cooldoger/cassandra/commit/31c4724c10830700356ed9cbfee24dab4601e0de]|
|[14422-3.11|https://github.com/cooldoger/cassandra/commit/7d2abcd2c29fa7cbcd114fc7e3152e39ed1016f6]|
The patch is to fix a dependency management issue, it won't change any
cassandra binaries or adding/removing any JARs. It only changes the metadata
pom. There're missing dependencies in the pom, for example:
http://central.maven.org/maven2/org/apache/cassandra/cassandra-all/3.11.2/cassandra-all-3.11.2.pom,
it's missing {{airline}} and {{ohc-core-j8}} in {{project->dependencies}}
list. If there's a project depends on
[{{cassandra-all-3.11.2.jar}}|http://central.maven.org/maven2/org/apache/cassandra/cassandra-all/3.11.2/cassandra-all-3.11.2.jar],
the dependency management tool (maven, gradle, etc.) won't be able to download
{{ariline}}/{{ohc-core-j8}} which are needed by {{cassandra-all-3.11.2.jar}}.
was (Author: jay.zhuang):
Sure, I split the change for easy review:
||Diff||
|[14422-3.0|https://github.com/cooldoger/cassandra/commit/31c4724c10830700356ed9cbfee24dab4601e0de]|
|[14422-3.11|https://github.com/cooldoger/cassandra/commit/7d2abcd2c29fa7cbcd114fc7e3152e39ed1016f6]|
The patch is to fix a dependencies management issue, it won't change any
cassandra binaries or adding/removing any JARs. It only changes the metadata
pom. There're missing dependencies in the pom, for example:
http://central.maven.org/maven2/org/apache/cassandra/cassandra-all/3.11.2/cassandra-all-3.11.2.pom,
it's missing {{airline}} and {{ohc-core-j8}} in {{project->dependencies}}
list. If there's a project depends on
[{{cassandra-all-3.11.2.jar}}|http://central.maven.org/maven2/org/apache/cassandra/cassandra-all/3.11.2/cassandra-all-3.11.2.jar],
the depedency management tool (maven, gradle, etc.) won't be able to download
{{ariline}}/{{ohc-core-j8}} which are needed by {{cassandra-all-3.11.2.jar}}.
> Missing dependencies airline and ohc-core-j8 for pom-all
> --------------------------------------------------------
>
> Key: CASSANDRA-14422
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14422
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Shichao An
> Assignee: Shichao An
> Priority: Minor
>
> I found two missing dependencies for pom-all (cassandra-all):
> * airline
> * ohc-core-j8
>
> This doesn't affect current build scheme because their jars are hardcoded in
> the lib directory. However, if we depend on cassandra-all in our downstream
> projects to resolve and fetch dependencies (instead of using the official
> tarball), Cassandra will have problems, e.g. airline is required by nodetool,
> and it will fail our dtests.
> I will attach the patch shortly
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
