[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496794#comment-16496794
]
Michael Shuler commented on CASSANDRA-14422:
--------------------------------------------
For future reference, here is the code style "policy"/suggestion on whitespace:
[https://cassandra.apache.org/doc/latest/development/code_style.html#whitespace]
Apologies if my suggestion was vague on the removal of whitespace changes to
the particular branch diffs, also seconded by Jeff. I assumed the subsequent
diffs posted for 3.0/3.11 were the ones that would be committed.
{{git blame build.xml}} forever more will have an irrelevant commit on many
lines, when only the code changes should have been committed to those branches.
Personally, I use blame frequently when looking for changes, so github trickery
means nothing and code reviews should follow the documented code style
suggestions.
> Missing dependencies airline and ohc-core-j8 for pom-all
> --------------------------------------------------------
>
> Key: CASSANDRA-14422
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14422
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Shichao An
> Assignee: Shichao An
> Priority: Minor
> Fix For: 4.0, 3.0.17, 3.11.3
>
> Attachments: deps-tree-311-no_patch.txt
>
>
> I found two missing dependencies for pom-all (cassandra-all):
> * airline
> * ohc-core-j8
>
> This doesn't affect current build scheme because their jars are hardcoded in
> the lib directory. However, if we depend on cassandra-all in our downstream
> projects to resolve and fetch dependencies (instead of using the official
> tarball), Cassandra will have problems, e.g. airline is required by nodetool,
> and it will fail our dtests.
> I will attach the patch shortly
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
